tensorflow / tensorflow/probability
Missing preference for parameters in tfp.math.psd_kernels.RationalQuadratic
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 4.4k
- Forks
- 1.1k
- PR merge metrics
- No merged PRs in 30d
Description
There are two exclusive parameters in tfp.math.psd_kernels.RationalQuadratic. The first is length_scale, and the second is inverse_length_scale. But both are marked as preferred -- it is the default value in the ParameterProperties.
If the length_scale is less stable, it should be changed to:
...
length_scale=parameter_properties.ParameterProperties(
is_preferred=False,
default_constraining_bijector_fn=(
lambda: softplus.Softplus(low=dtype_util.eps(dtype)))),
...
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tensorflow_probability/python/math/psd_kernels/rational_quadratic.py around line 214 and inspect the ParameterProperties for the two exclusive parameters. Confirm which parameter should be preferred, update the metadata accordingly, and verify the RationalQuadratic tests covering parameter selection and constraining bijectors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, tensorflow
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100