tensorflow / tensorflow/probability

Tensorflow Probability Glow has duplicated variable names

Open
#1,503 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
4.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Hi,

I am playing with the default Glow model implemented in tensorflow_probability and I find that many variables have duplicated names in the graph (e.g. many variables are called 'Variable:0'). That prevents, for example, saving the model in an h5 file.

Am I doing something wrong? Reproducible code below

import tensorflow as tf
import tensorflow_datasets as tfds
import tensorflow_probability as tfp
import math
tfd = tfp.distributions
tfb = tfp.bijectors

class GlowModel(tf.keras.Model):
    def __init__(self, input_shape, **kwargs):
        super(GlowModel, self).__init__(**kwargs)
        self.glow = tfb.Glow(output_shape=input_shape,
                        coupling_bijector_fn=tfb.GlowDefaultNetwork,
                        exit_bijector_fn=tfb.GlowDefaultExitNetwork,
                        num_glow_blocks=3,
                        num_steps_per_block=32)
        z_shape = self.glow.inverse_event_shape(input_shape)

        self.pz = tfd.Sample(tfd.Normal(0., 1.), z_shape)

        self.px = self.glow(self.pz)

    def call(self, inputs, training=None, **kwargs):
        return self.px
    
model = GlowModel(input_shape=(32, 32, 1))
print(model.trainable_variables)

Thanks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the reproducible GlowModel example and inspecting model.trainable_variables. Read tfb.Glow, tfb.GlowDefaultNetwork, and tfb.GlowDefaultExitNetwork to determine where variable names are assigned; done means the model has distinct variable names and can be saved to an H5 file.

Written by the indexing model from the issue text.

Assessment

Tech stack
tensorflow
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.