tensorflow / tensorflow/probability

BFGS user should be able to pass parameters to the line search

Open
#1,043 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue
Dominant language
Jupyter Notebook
Stars
4.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

This should just be a matter of accepting a dict named line_search_kwargs or such and passing it through to the actual line search.

This was a feature request that came out of discussing #1034.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the BFGS implementation and the point where it invokes the line search. Read the discussion in #1034 for the requested behavior, then trace the existing line-search call and its tests. Done means callers can provide a line_search_kwargs dictionary and those parameters reach the actual line search, with coverage for the forwarding behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
tensorflow
Domain
machine-learning
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.