tensorflow / tensorflow/models

there are too many keys\ids in the object_detection dataset. so error message "image_id" is confusing

Open
#8,712 1 comment 0 reactions 3 assignees View on GitHub

@pkulzc is already working on this.

Since Jun 22, 2020.

models:research:odapi type:support
Dominant language
Python
Stars
77.7k
Forks
44.8k
PR merge metrics
No merged PRs in 30d

Description

for a some reason, there are several keys in the object detection record

  • filename
  • source_id
  • key

but in the code, it's even more confusing - the same field named "hash", "key", "image_id"
so when user creates invalid eval dataset, there are warnings like

"Missing ground-truth for image id: ",
"Ignoring detection with image id %s since it was previously added"

but image_id in the message is nothing from the user-defined keys.
see
https://github.com/tensorflow/models/blob/eb355ec0801fe59600c53e2302c3e1b81ba7e9c0/research/object_detection/inputs.py#L625

and

https://github.com/tensorflow/models/blob/eb355ec0801fe59600c53e2302c3e1b81ba7e9c0/research/object_detection/model_lib.py#L536

it is a hash of the source_id! o.O

Very confusing, and it makes debug dataset issues hard.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.