tensorflow / tensorflow/models

Incrementing Worker.global_episode in Worker.run() in a3c_cartpole.py

Open
#8,498 1 comment 0 reactions 2 assignees View on GitHub

@MarkDaoust is already working on this.

Since May 13, 2020.

models:research type:bug
Dominant language
Python
Stars
77.7k
Forks
44.8k
No merged PRs in 30d

Description

In the following code the Worker.global_episode is incremented once a thread reaches the end of its own episode. But, should Worker.global_episode not be incremented once ALL threads reach their own end of episode?

if done: # done and print information
.
.
Worker.global_episode += 1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.