tensorflow / tensorflow/java

SparseNDArray and SparseTensor.

Open
#352 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
928
Forks
227
PR merge metrics
No merged PRs in 30d

Description

This may be a more appropriate issue for java-ndarray, but I thought I would kick off discussion here as it relates to SparseTensor.

@karl has asked that I explore setting up a SparseNDArray within java-ndarray, and I have done that partially, but I thought I would highlight some issues I am running up against.

I started writing a SparseNDArray under a new package (sparse) in java-ndarray.
A Sparse Array contains a dense shape, indices of coordinates as a LongNDArray, and a set of values as
U extends NdArray<T> array (e.g. FloatSparseNdArray would have a FloatNDArray for the values).
The indices would contain a set of coordinates in the dense shape space that would match non-zero values in the hypothetical dense array that the sparse array represents. The index of the matched coordinates would also be the index into the Values array for the corresponding value entry.

The indices shape is [N, ndims], where N is the number non-zero values, and ndims is the number of dimensions in the dense shape. The values shape is [N], or the number of non-zero values.

It is straight forward to create an AbstractSparseNdArray class and a subclass, e.g FloatSparseNdArray. It is also straight forward to get a value based on getObject using full coordinates. First do a binary search of the sorted indices and if the there is a match, return the corresponding value from the values ndarray, else return zero.

When doing the setObject commands it becomes a little more complicated. If it is changing one non-zero value to another non-zero value, then just change the corresponding entry in the values array. However, if the value changes from zero to non-zero, one has to add to the indices and values arrays. Likewise, if a value changes from non-zero to zero, it entails removing the corresponding entries in the indices and values. This, on the surface, creates a lot of objects, and we have already mentioned object creation as a problem in java-ndarray. (A work around for the non-zero to zero problem would be to just set the value in the values array to zero.)

Some other patterns in java-ndarray are very problematic.

For example,

  1. What does parse.elements(dimensionIdx) mean? Is dimensionIdx equivalent to a row in the dense matrix? How do you iterate the elements?
  2. How do you slice the sparse array? Presumably, there would have to be a window into the sparse array. In the existing NDArray classes this is done via a DataBuffer and DataBufferWindow which are dense and do not apply to sparse.
  3. What does NdArray<T> get(long... coordinates) mean? How do you get an NDArray if you only provide partial coordinates? For partial coordinates, the concept of a higher dimension NDArray does not make sense unless it is converted to dense.
  4. Same issue with NdArray<T> set(NdArray<T> src, long... coordinates) ( but one could walk the src array and pull out non-zero entires and make the internal modifications).

One option to deal with these issues is to make all or part of the sparse array dense when required, but doesn't that defeat the purpose of a sparse array?

In looking for how other packages deal with sparse matrices, an analogous class in SciPy, scipy.sparse.coo_matrix states:
scipy.sparse.coo_matrix

Disadvantages of the COO format
   does not directly support:
       arithmetic operations
       slicing

It is also noteworthy, the the coo_matrix class is in the SciPy package and not in NumPy, so it is not constrained by NumPy.array semantics.

My first question is do we need all this complexity to represent a SparseTensor, or is there a simpler way to create it without dealing with all the ambiguities between Sparse and Dense in the java-ndarray package? This is what Python TF did with the SparseTensor class. In Python TF SparseTensor, the dense_shape, indices and values are Tensors that are passed to the tf.sparse low level APIs. The SparseTensor is a Tensor that is passed in higher level operations, but it is a first class Tensor.

I would appreciate any thoughts on this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the java-ndarray package and the existing NdArray, DataBuffer, and DataBufferWindow semantics, then compare the proposed AbstractSparseNdArray and FloatSparseNdArray with SciPy COO and TensorFlow SparseTensor. Done requires a decided representation and documented behavior for indexing, slicing, partial coordinates, and zero-value updates.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, python, tensorflow
Domain
data, machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.