tensorflow / tensorflow/java

Tighten floating-point comparison tolerances in tests.

Open
#219 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
928
Forks
227
PR merge metrics
No merged PRs in 30d

Description

As of this writing, we have tests with wide floating-point comparison tolerances. See, for example, call paths into TestSession.setEpsilon(...). @JimClarke5 reports, "I have seen a wide difference in the number of significant digits in other test cases when I use Java to determine the expected result."

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating test call paths into TestSession.setEpsilon(...) and review the floating-point comparisons highlighted in the issue and linked review comment. Tighten the overly wide tolerances while preserving reliable expected-result comparisons; done when the affected tests pass with narrower tolerances.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.