tensorflow / tensorflow/graphics

Better parameters names for io/triangle_mesh.py

Open
#403 0 comments 0 reactions 1 assignee View on GitHub

@segaviv is already working on this.

Since Jun 30, 2020.

Dominant language
Python
Stars
2.8k
Forks
374
No merged PRs in 30d

Description

https://github.com/tensorflow/graphics/blob/946aa03b5178d2fc557a81045b84df24af322afd/tensorflow_graphics/io/triangle_mesh.py#L42

I think "filepath_or_object" would be a more appropriate parameter name?
For a second, I was convinced obj stood for OBJ (as in Alias Wavefront Obj).

Thoughts?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.