tensorflow / tensorflow/datasets

Fails on Windows due to different path separators

Open
#4,247 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4.6k
Forks
1.6k
Avg merge
3h 54m
Merged PRs (30d)
1

Description

https://github.com/tensorflow/datasets/blob/8be539d09ed977df1b60b45f4e3237273812f638/tensorflow_datasets/audio/speech_commands.py#L193

In windows, the 'train_test_paths' and 'validation_paths' are not completely removed from 'train_paths'.
'train_paths' has '\' as path separator
'train_test_paths' and 'validation_paths' have '/' as path separator

This results in train and validation sets not split as expected.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at tensorflow_datasets/audio/speech_commands.py around line 193 and inspect how train_paths is compared with train_test_paths and validation_paths on Windows. Reproduce the path-separator mismatch and verify that the resulting train, test, and validation sets are split as expected on Windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, tensorflow
Domain
data
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.