Bucket name ending with '/' may error out.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 383
- Forks
- 93
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 1
Description
From: @yixingfu
Path ending with / makes a problem. For example, when setting path as ‘gs://[BUCKET_NAME]/saves’ works fine, but ‘gs://[BUCKET_NAME]/saves/’ breaks down when trying to reload in remote. For example, running “call_run_on_script_with_keras_save_and_load.py” in the integration test, the log stops updating after the following one:
But the job keeps running. I manually killed the job after a while. I think it is because the extra ‘/’ preventing it from correctly loading. Maybe an error should be raised? Or remove any trailing ‘/’ when parsing the path?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with call_run_on_script_with_keras_save_and_load.py in the integration tests and compare remote loading for paths ending with and without '/'. Trace the path parsing and loading entry point to determine where the trailing slash causes the job to stop updating; done means the behavior is handled consistently and the integration case completes or reports a clear error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- keras, python, tensorflow
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100