make tutorial directory a variable (and don't run jupyter as root)
Open
Nobody has claimed this yet.
sig build dockerfiles
- Dominant language
- Shell
- Stars
- 311
- Forks
- 139
- Avg merge
- 1h 28m
- Merged PRs (30d)
- 1
Description
Instead of the hardcoded "/tf" a variable ${TENSORFLOW_NOTEBOOK_DIR} should be used.
When I derived my own image from one of yours I let jupyter notebook run as non-root user and could not access the tensorflow-tutorials notebooks in /tf/tensorflow-tutorials.
In the long run, jupyter should not run as root - and users shouldn't have to adjust this on their own.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the image configuration and startup entry points that hardcode /tf and launch Jupyter. Trace how the tutorial notebooks are placed and how the notebook process is started, then verify that TENSORFLOW_NOTEBOOK_DIR controls access for a non-root user and that Jupyter no longer runs as root.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter, shell
- Domain
- build-system, devops
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100