temporalio / temporalio/ui

filtering values containing quotes does not work

Open
#1,714 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
431
Forks
179
Avg merge
2d 9h
Merged PRs (30d)
71

Description

Describe the bug

When trying to filter by workflow ID (and maybe other fields) that contains the character ", the query generated is not valid.

To Reproduce
Steps to reproduce the behavior:

  1. have a workflow running with the character " in its name
  2. Go to Recent Workflows
  3. Click on Filter Workflows when hoovering the Workflow ID
  4. See error

Expected behavior

The query is properly escaped so the workflows are queried and displayed (I don’t know which query language is used and if escaping is properly supported there)

Screenshots

image

image

Desktop (please complete the following information):

  • OS: windows 10
  • Browser: firefox
  • Version: 118.0.2

Additional context

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue from Recent Workflows using a workflow ID containing a double quote, then trace the Filter Workflows action to where its query is generated. Verify which query language is used and confirm that the escaped query returns and displays the matching workflow.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, search
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.