temporalio / temporalio/ui

Any interest in dropping dependency on "dockerize"

Open
#1,703 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
431
Forks
179
Avg merge
2d 9h
Merged PRs (30d)
71

Description

Is your feature request related to a problem? Please describe.

I noticed that start-server-ui.sh uses dockerize for templating this file.

This isn't a problem per se, but it does add ~6MB to your image size to do some fairly mundane template rendering.

Describe the solution you'd like

Looking at the template, I see that it uses default and split functions, which are not particularly complicated. This seems like something that could be implemented in the fs_config_loader directly rather than via packaging an additional binary in the docker image.

Would there be any interest in a PR that does something like this? Either through a separate subcommand of ui-server or via a flag?

Describe alternatives you've considered

Do nothing.

Additional context

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with server/docker/start-ui-server.sh and server/docker/config-template.yaml to understand how dockerize currently renders the configuration. Then inspect the fs_config_loader and ui-server entry points mentioned in the issue. Done means the template still supports the default and split functions without packaging dockerize in the image; verify the resulting Docker image and configuration behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker
Domain
devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.