temporalio / temporalio/temporal
remove version check and 9s const after v1.27 release
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
- in #7385, @alexshtin added:
https://github.com/temporalio/temporal/blob/ab20b732ca948c05da2c5e398a93c7d41231dff0/service/worker/deletenamespace/reclaimresources/workflow.go#L156-L157
https://github.com/temporalio/temporal/releases/tag/v1.27.0 was released 11 months ago.
https://github.com/temporalio/temporal/releases/tag/v1.28.0 was released in June
https://github.com/temporalio/temporal/releases/tag/v1.29.0 was released in October
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in service/worker/deletenamespace/reclaimresources/workflow.go at the lines linked from issue #7385. Inspect the version check and 9-second constant, then remove the obsolete logic now that v1.27 and later releases are available. Done means the old version-dependent check and constant are gone without affecting the surrounding workflow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100