temporalio / temporalio/temporal
Set log level of dynamic config updated message in file_based_client to warn instead of info
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
https://github.com/temporalio/temporal/blob/main/common/dynamicconfig/file_based_client.go#L193
Currently users have to set log level in static config to "info" to see this message. Message can be pretty
important to have in logs to know that dynamic config changes have been applied (and when according to
timestamp)
Request is to change this log message to Warn so that users don't have to set their log level to info and get bombarded with tons more logs, but still can see this one.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open common/dynamicconfig/file_based_client.go at the referenced line and inspect the dynamic-config update log message. Change its level to warn, then verify the file-based client tests cover the update path and confirm the message is emitted at warn.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100