temporalio / temporalio/temporal

Don't log a warning when task queue kind is unspecified

Open
#8,322 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

Is your feature request related to a problem? Please describe.

The temporal server logs the following log line every time a task runs without the task queue kind set:

level=WARN msg="Unspecified task queue kind" service=frontend wf-task-queue-name=devbox-temporal-server:pay-server:shared wf-namespace=dev>

As a result, it dominates server log output. kind is well-documented to default to "Normal", so it seems odd to warn about this behavior.

The Ruby SDK we are using does not pass kind, so every Ruby task we run generates this log line. This seems like a high amount of logs for a non-issue!

Source of log line: https://github.com/temporalio/temporal/blob/5c26e48486a412d212e88a6faba14d3439627111/service/frontend/workflow_handler.go#L859

Describe the solution you'd like

Don't emit this log line by default. Maybe move it to a verbose option if it's useful for some.

Describe alternatives you've considered

We may try to patch our Ruby SDK to pass kind to silence this log line, but I believe the community would benefit from less log chunder.

Additional context
None.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at service/frontend/workflow_handler.go around the warning source at line 859 and inspect how an unspecified task queue kind is handled. Verify the behavior when kind is omitted and make the default path stop emitting the warning while preserving the documented Normal default.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.