temporalio / temporalio/temporal

Handle Permission Errors in getConfigFiles Function

Open
#7,048 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

The getConfigFiles function doesn't handle permission errors properly. Right now, if it can't read a file because of permission issues, it just skips it without letting us know.

https://github.com/temporalio/temporal/blob/2d8afd44c413a25c53f5fe8eecff3cbbbb782fba/common/config/loader.go#L135C1-L140C3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read common/config/loader.go at the linked getConfigFiles implementation and trace how file-read errors are handled. Determine how permission failures should be surfaced rather than silently skipped, then verify that the function reports them while preserving expected handling of readable files.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.