temporalio / temporalio/temporal
Extend activity retry expiration time upon reset
Open
Nobody has claimed this yet.
potential-bug
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Expected Behavior
- Activity retry expiration time should be re-calculated based on the reset time
Actual Behavior
- Activity retry expiration time is based calculated using the base workflow's activityScheduleEvent time.
- Then activity scheduled time is overwritten to the reset time, causing activity scheduled time to be later than retry expiration time. https://github.com/temporalio/temporal/blob/main/service/history/ndc/workflow_resetter.go#L562
Steps to Reproduce the Problem
Specifications
- Version:
- Platform:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in service/history/ndc/workflow_resetter.go around line 562 and trace how the activity retry expiration time is calculated during workflow reset. Confirm that the expiration is recalculated from the reset time rather than the base workflow activity schedule time, and verify that the reset activity schedule does not exceed it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100