temporalio / temporalio/temporal
Why is the default value of the SDK client grpc "MaxSendMsgSize" inconsistent with the server grpc "MaxRecvMsgSize"?
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
The server grpc "MaxRecvMsgSize" iuses the default value of 4M and is not rewritten, but the client sdk grpc "MaxSendMsgSize" is rewritten to 128M. What is the reason for this?
server:
func NewService(
server *grpc.Server,
serviceConfig *configs.Config,
visibilityMgr manager.VisibilityManager,
handler *Handler,
logger log.Logger,
grpcListener net.Listener,
membershipMonitor membership.Monitor,
metricsHandler metrics.Handler,
healthServer *health.Server,
) *Service {
return &Service{
server: server,
handler: handler,
visibilityManager: visibilityMgr,
config: serviceConfig,
logger: logger,
grpcListener: grpcListener,
membershipMonitor: membershipMonitor,
metricsHandler: metricsHandler,
healthServer: healthServer,
}
}
client:
defaultMaxPayloadSize = 128 * mb
...
opts = append(opts, securityOptions...)
opts = append(opts, grpc.WithDefaultCallOptions(grpc.MaxCallSendMsgSize(maxPayloadSize)))
opts = append(opts, grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(maxPayloadSize)))
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the server NewService entry point and the client code containing defaultMaxPayloadSize and the grpc call options. Compare how the server MaxRecvMsgSize and client MaxSendMsgSize defaults are configured; done means the reason for the difference is established and clearly recorded.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, grpc
- Domain
- backend-api-design, distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100