temporalio / temporalio/temporal
Make option for UpsertSearchAttribute command to fail if SA does not exists
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
Currently, if workflow try to upsert SA from within the workflow and it does not exists, the workflow task will fail and keep retrying forever.
Describe the solution you'd like
Give option for workflow to fail the command if SA does not exists
Describe alternatives you've considered
Work around is to use activity/localActivity to check if SA exists before call upsertSA.
But really the author should make sure the SA exists before the use case go online. Create SA should be handed as one time job and should not be created dynamicly. If you find that you need to create SA dynamicly, you probably doing it wrong. The number of SA is very limited.
Additional context
Add any other context or screenshots about the feature request here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the UpsertSearchAttribute command and its workflow execution path. Determine how an option should distinguish a missing search attribute from the current retry behavior, then add coverage for the failure and existing-attribute cases. Done means a workflow can choose to fail the command when the search attribute does not exist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design, distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100