temporalio / temporalio/temporal
Unit test error in v1.24.2
Open
Nobody has claimed this yet.
potential-bug
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Expected Behavior
Unit tests should pass
Actual Behavior
Unit tests do not pass
Steps to Reproduce the Problem
- Checkout tag
v1.24.2orrelease/v1.24.x - Run unit tests, either via
make unit-test-coverageorgo test ./service/history/workflow/... - Observe failure
=== Failed
=== FAIL: service/history/workflow TestMutableStateSuite/TestTotalEntitiesCount (0.00s)
2024-07-22T22:38:14.867Z info Task key range updated {"number": 1048576, "next-number": 2097152, "logging-call-at": "task_key_generator.go:177"}
controller.go:231: missing call(s) to *cluster.MockMetadata.ClusterNameForFailoverVersion(is equal to false (bool), is equal to 1234 (int64)) /home/runner/work/temporal/temporal/service/history/workflow/mutable_state_impl_test.go:1087
controller.go:231: missing call(s) to *cluster.MockMetadata.GetCurrentClusterName() /home/runner/work/temporal/temporal/service/history/workflow/mutable_state_impl_test.go:1091
controller.go:231: aborting test due to missing call(s)
=== FAIL: service/history/workflow TestMutableStateSuite (0.05s)
DONE 4541 tests, 7 skipped, 2 failures in 665.189s
make: *** [Makefile:405: unit-test-coverage] Error 1
Specifications
- Version: v1.24.2
- Platform:
Current runner version: '2.317.0'
Operating System
Ubuntu
[2](https://github.com/bigeyedata/temporal/actions/runs/10049193855/job/27775132542?pr=19#step:1:2)2.04.4
LTS
Runner Image
Image: ubuntu-22.04
Version: 20240714.1.0
Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20240714.1/images/ubuntu/Ubuntu2204-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240714.1
Runner Image Provisioner
2.0.[3](https://github.com/bigeyedata/temporal/actions/runs/10049193855/job/27775132542?pr=19#step:1:3)70.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure with make unit-test-coverage or go test ./service/history/workflow/... on v1.24.2. Read service/history/workflow/mutable_state_impl_test.go around the reported lines 1087 and 1091, along with the failing TestTotalEntitiesCount. Done means the missing mock calls are resolved and the workflow unit tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100