temporalio / temporalio/temporal
Flaky versioning issue when querying since 1.24
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Expected Behavior
https://github.com/temporalio/sdk-dotnet/blob/a87116418c526bb76e0cc11f951d6f8648b71e01/tests/Temporalio.Tests/Worker/WorkerVersioningTests.cs#L53-L55 works with pre-1.24 servers without flake.
Actual Behavior
https://github.com/temporalio/sdk-dotnet/blob/a87116418c526bb76e0cc11f951d6f8648b71e01/tests/Temporalio.Tests/Worker/WorkerVersioningTests.cs#L53-L55 now flakes. Querying a workflow with versioning for some reason sometimes now times out (i.e. gets "Timeout expired" RPC failure). This only occurs on slower GitHub runners (I wonder if there is some issue with UpdateWorkerBuildIdCompatibility not being strongly consistent). Marking that test skipped and opening this issue at @ShahabT's request.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/Temporalio.Tests/Worker/WorkerVersioningTests.cs at lines 53-55 and reproduce the query timeout on slower GitHub runners. Then investigate the UpdateWorkerBuildIdCompatibility behavior mentioned in the report. Done means the versioning query test can run without intermittent "Timeout expired" RPC failures against the affected server versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, go
- Domain
- distributed-systems, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100