temporalio / temporalio/temporal
Add proper unit / integration tests for parentclosepolicy workflow
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Context: We had a nil ref bug in the workflow where the activity was not passing in a context, which meant that this Workflow was always failing. Although we fixed the bug, there is a lack of unit/integration testing that should have protected us against this (it was caught by stress testing, but that is far too late to catch such a basic issue)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the parentclosepolicy workflow and existing workflow unit or integration tests, then read how activities receive context. Add coverage for the workflow path that previously failed when the activity context was missing, and verify the new tests pass without relying on stress testing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100