temporalio / temporalio/temporal
Limit failure cause depth
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Describe the solution you'd like
Users can set very deep failure causes, and once it gets past 30 or so it breaks some protobuf parsers (any based on upb like Python and maybe Ruby/C/C++). We should limit the depth to something like 10/15. Can discuss implementation design on how this limitation occurs (not sure we should reject the failure but up to implementer). I can also provide more exact numbers on how deep before Python fails if that information is needed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how failure causes are represented and processed in the Temporal service, then reproduce the protobuf parser failure with deeply nested causes, especially through upb-based clients. Define the acceptable depth and whether excessive causes are rejected or limited, and verify the chosen behavior across the affected client paths.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100