temporalio / temporalio/temporal
Use different error when signalName is empty than errSignalNameTooLong
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Feature request is to add a new error message when signalName is empty:
Currently used is https://github.com/temporalio/temporal/blob/main/service/frontend/workflow_handler.go#L1629-L1631
SignalNameTooLong
which is a bit confusing
Thanks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in service/frontend/workflow_handler.go around lines 1629-1631 and inspect how signalName validation currently selects SignalNameTooLong. Define the separate empty-name error behavior there, then verify that empty and overlong signal names produce distinct errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100