temporalio / temporalio/temporal
Identifiers length validation
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
The PostgreSQL schema limits identifier lengths to 255 characters. So I set limit.maxIDLength to 255 as well for server-side validation because I don't want to have any errors on the database level. However, len(someString) in Go returns byte size, not character count, causing issues with multi-byte characters in identifiers.
Describe the solution you'd like
limit.maxIDLength in symbols rather than bytes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Go validation for identifiers and the definition or uses of limit.maxIDLength in symbols. Check how identifier lengths are measured, especially for multi-byte characters, and review any nearby validation tests. Done means server-side validation measures the intended character limit consistently with the PostgreSQL schema.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, postgresql
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100