temporalio / temporalio/temporal
Provide WorkflowStatus in when signing a workflow that is closed
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
Currently signaling a closed workflow will throw error, but there are several cases:
- Workflow really doesn't exist (or deleted after retention)
- Workflow is completed/terminated/etc (closed)
As an application, we sometimes need to handle the two cases differently(error handling).
Describe the solution you'd like
The error should should be able to return "WorkflowStatus" inside.
Describe alternatives you've considered
Currently we have to make a DescribeWorkflowExecution API call to achieve this. This requires more code, more error handling, and higher latency .
Additional context
https://github.com/temporalio/sdk-java/issues/1969
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by tracing the closed-workflow signaling path and the existing error returned by that operation, then compare it with DescribeWorkflowExecution. Done means the error exposes WorkflowStatus for closed workflows while allowing applications to distinguish them from workflows that do not exist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100