temporalio / temporalio/temporal
Retry Policy should be copied to the continued as new workflow.
Open
Nobody has claimed this yet.
potential-bug
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Expected Behavior
When a retry policy is not set in the ContinueAsNewWorkflowExecutionCommandAttributes continued workflow should have the same policy as the previous workflow run.
Actual Behavior
The continued workflow doesn't have the retry policy set.
Steps to Reproduce the Problem
- Set retry policy on a workflow.
- Call continue as new
- Verify that the next workflow doesn't have retry policy set.
The code that should perform the merge:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at service/history/workflow/mutable_state_impl.go around line 1630 and trace the merge for ContinueAsNewWorkflowExecutionCommandAttributes. Follow the listed reproduction steps, then verify that omitting a retry policy preserves the previous workflow run's policy in the continued workflow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100