temporalio / temporalio/temporal

Bearer token not passed to remote cluster when adding or upserting remote cluster

Open
#4,823 0 comments 1 reaction 1 assignee View on GitHub

@dnr is already working on this.

Since Sep 1, 2023.

potential-bug
Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

Set up:
2 seperate running clusters, Cluster-1 and Cluster-2. Both are configured with custom authorizers with OAuth authorization.

Expected Behavior

  1. Request-1: addOrUpsertRemoteCluster request to Cluster-1 with bearer token.
  2. Request-1 passes authorization check on Cluster-1
  3. Frontend service from Cluster-1 makes a Request-2 to Cluster-2 with propagated token from Request-1
  4. Request-2 passes authorization check on Cluster-2

Actual Behavior

  1. Request-1: addOrUpsertRemoteCluster request to Cluster-1 with bearer token.
  2. Request-1 passes authorization check on Cluster-1
  3. Frontend service from Cluster-1 makes a Request-2 to Cluster-2 does not propagate token from Request-1
  4. Request-2 fails authorization check on Cluster-2

Steps to Reproduce the Problem

  1. Run 2 seperate clusters with OAuth authorizers (set them up to deny request with emtpy tokens)
  2. Make a request addOrUpsertRemoteCluster :
    temporal operator cluster upsert --frontend-address 'remote.address' --grpc-meta 'authorization=bearer TOKEN'

Specifications

  • Version: 1.20.3
  • Platform: kubernetes, docker compose, any.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.