temporalio / temporalio/temporal

Could taskReader persistAckLevel check last persist ackLevel avoid persist duplicate ackLevel

Open
#4,692 1 comment 0 reactions 1 assignee View on GitHub

@dnr is already working on this.

Since Jul 28, 2023.

enhancement
Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

Is your feature request related to a problem? Please describe.
Some workflow worker or actvitiy worker just startup wait for task coming but maybe hold for long time. Here are may no task coming for a long while. Persist acklevel cause effortless database request per updateAckTimer.

Describe the solution you'd like
taskReader store last persist ack level and do persistAckLevel only when current ack level not match last persist ack level.

Describe alternatives you've considered
No

Additional context
No

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.