temporalio / temporalio/temporal

Add metrics when history service writes activity task failed to even history

Open
#4,171 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

https://github.com/temporalio/temporal/blob/master/service/history/api/respondactivitytaskfailed/api.go#L124-L131

It would be imo useful to add counter metric here so that user can track how often service has failed activity for retries exhausted

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at service/history/api/respondactivitytaskfailed/api.go#L124-L131 and trace the failure path for exhausted activity retries. Determine how this service records metrics, then add coverage so the counter is emitted for this failure and verify the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems, observability
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.