temporalio / temporalio/temporal
Clear signal requestID on workflow close
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
Signal requestID is for dedupping signal request. After workflow close, all signal requests will be rejected, so we don't really need signal requestIDs for dedupping.
Describe the solution you'd like
- Clear signal requestID on workflow close
- However, we may need it for https://github.com/temporalio/temporal/issues/4028. If that's the case, we can persist the requestID as part of the signaled event, so that upon reset, the signal requestID map can be rebuilt.
Describe alternatives you've considered
- We don't have to do it if we believe we won't benefit much from making this change.
Additional context
Add any other context or screenshots about the feature request here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing workflow-close handling and the signal requestID map, then read issue #4028 to determine whether reset requires requestIDs to persist in signaled events. Confirm the expected behavior for closed workflows and whether the map can be cleared safely; done means signal requests remain rejected after close without breaking the reset scenario.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100