temporalio / temporalio/temporal

Signal requestID dropped upon workflow reset

Open
#4,028 0 comments 0 reactions 1 assignee View on GitHub

@dandavison is already working on this.

Since Aug 10, 2023.

potential-bug
Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

Expected Behavior

I am not sure if this is expected or not, but at least existing behavior looks weird to me

  • On workflow reset, signal got picked to the new run together with corresponding signal requestID so that dedup can still work.

Actual Behavior

  • After reset, signal event got picked but not signal request ID.

Steps to Reproduce the Problem

  1. Change tctl code to include a requestID when sending signals
  2. Start a workflow
  3. Use the modified tctl to signal it several time.
  4. Terminate the workflow started in 2
  5. Run tctl admin desc command, signalRequestedIds field is shown.
  6. Reset the workflow to first workflow task (any reset type will do I think, but I haven't verified)
  7. Run tctl admin desc command for the new run, there's no signalRequestedIds field.

Specifications

  • Version: master
  • Platform:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.