temporalio / temporalio/temporal
Signal requestID dropped upon workflow reset
Open
@dandavison is already working on this.
Since Aug 10, 2023.
potential-bug
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Expected Behavior
I am not sure if this is expected or not, but at least existing behavior looks weird to me
- On workflow reset, signal got picked to the new run together with corresponding signal requestID so that dedup can still work.
Actual Behavior
- After reset, signal event got picked but not signal request ID.
Steps to Reproduce the Problem
- Change tctl code to include a requestID when sending signals
- Start a workflow
- Use the modified tctl to signal it several time.
- Terminate the workflow started in 2
- Run
tctl admin desccommand,signalRequestedIdsfield is shown. - Reset the workflow to first workflow task (any reset type will do I think, but I haven't verified)
- Run
tctl admin desccommand for the new run, there's nosignalRequestedIdsfield.
Specifications
- Version: master
- Platform:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.