temporalio / temporalio/temporal
Change ParentClosePolicy to struct and add applyOnParentContinueAsNew
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
Currently a ParentClosePolicy is always applied when parent calls continue as new. In the majority of the cases it is not a desired behaviour and the policy should be applied only when a parent completes its execution.
Describe the solution you'd like
Change ParentClosePolicy to a structure with two fields: The current ParentClosePolicy enum and
applyOnParentContinueAsNew. When applyOnParentContinueAsNew is set to true then the policy applies when parent continues as new. When set to false only when parent completes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ParentClosePolicy definition and the workflow handling for parent completion and continue-as-new. Trace every use of the current enum before assessing the struct change and its compatibility impact. Done means the new applyOnParentContinueAsNew behavior is consistently enforced for both parent outcomes, with relevant tests updated or added.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100