temporalio / temporalio/temporal

Reset should be allowed with pending childWF in current run, if current run is already closed

Open
#3,624 6 comments 2 reactions 1 assignee View on GitHub

@yiminc is already working on this.

Since Nov 20, 2022.

Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

https://github.com/temporalio/temporal/blob/0c735e4969e95ff8c113fc73ed15fca1bc2999c2/service/history/ndc/workflow_resetter.go#L290

Mirror issue https://github.com/uber/cadence/issues/5030

This is because child WF could get get closed after parent closed, and parent will not receive the children close signals.

So that after parent is closed for any reasons(terminate/timeout/fail/etc), this parent is never allowed to reset to anywhere because it has a pending childWFs in its mutableState forever as "deadlock condition"

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.