temporalio / temporalio/temporal
Replace metrics and retryable client with client interceptors
Open
@dnr is already working on this.
Since Aug 5, 2022.
enhancement
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Please check the comment here:
https://github.com/temporalio/temporal/pull/3172#discussion_r935047507
Currently we use code generation for generating metrics/retryable client (a wrapper for basic/raw service clients) for logging/metrics and retry rpc calls. We have the same logic at the server/receiver end but is achieved via grpc interceptors.
Looks like the same approach can be applied to client side as well, and avoid the complexity of code generation and the cost for maintaining it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.