temporalio / temporalio/temporal
Improved per task queue metrics
@maoyi16 is already working on this.
Since Jul 27, 2022.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
The current per task queue metrics have a per_tl suffix as a hang-over from Cadence which uses the term task list. The taskqueue label uses the task queue name for the label on the root partitions but the internal partition task queue name for the partitions. This makes it difficult to sum the metrics across partitions in order to check, for example, polling sync rates for the task queue as a whole.
Describe the solution you'd like
I suggest adding new metrics with _per_taskqueue naming. This will make it easier to discover the metric as it uses the correct Temporal term (rather than tl for task list). The metrics should have their root taskqueue for the taskqueue labels and a partition label which records their task queue partition (0 for the root). This will make it easy to sum values for the task queue as a whole, and also viable to know how many partitions a task queue currently has which is not currently exposed in an easy to consume way.
The old metric would continue to be emitted but deprecated after some number of releases.
Describe alternatives you've considered
An alternative would be to amend the labels for the existing metric names but this will break existing dashboards/alerting and cause confusion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.