temporalio / temporalio/temporal
Do not emit metrics when acquire shard r/w lock
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
CPU profiling shows that logic probably should not emitting metrics during / before acquisition of shard r/w lock.
Describe the solution you'd like
Either do not emit metrics when acquiring shard r/w lock or at least do sampling
Describe alternatives you've considered
N/A
Additional context
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing shard read/write lock acquisition and the metrics emitted during or before that path, using the CPU profile as context. Determine whether metrics can be excluded safely or sampled, then verify that lock acquisition no longer causes the reported metric overhead.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems, observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100