temporalio / temporalio/temporal
Fix names of dynamic config properties
Open
@Ardagan is already working on this.
Since Jul 3, 2021.
API
config
difficulty: easy
refactoring
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Names of dynamic config properties are not consistent. Some of them start from capital letter, some of them from lower case. Some of them use abbreviations as "num", "max", while others use the whole words.
The same applies to the contant names. Some of them are prepended with the component like Worker, Matching, History, but the large number of them is not.
Also sorting them in the alphabetic order per component would make sense.
https://github.com/temporalio/temporal/blob/master/common/service/dynamicconfig/constants.go
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.