temporalio / temporalio/temporal
Do not load all persistence libraries unless needed
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Currently, we load all persistence libraries no matter what persistence the server is configured to run with.
With recent added auth plugin, we are now also pull in aws libraries for "rds-iam-auth". This will quickly become unsustainable.
We need a better way to be able to load only needed libraries.
Few options I can think of:
- Build plugins as library and load dynamically at runtime based on persistence config.
- Use different build flag to include only needed libraries at build time for persistence used. This will result in different binaries for different persistence.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are identified in the issue. Start by tracing how persistence configuration currently loads libraries and how the rds-iam-auth plugin brings in AWS dependencies; define completion as loading only the libraries required by the configured persistence backend without breaking supported build or runtime configurations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, go
- Domain
- backend, build-system, databases
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100