temporalio / temporalio/temporal
Populate identity for child workflows
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
temporal.api.history.v1.WorkflowExecutionStartedEventAttributes.identity is populated with the client identity when started from a client, but not populated with a value when it's a child workflow.
Describe the solution you'd like
Use temporal.api.workflowservice.v1.RespondWorkflowTaskCompletedRequest.identity for the child workflow identity. SDKs set this as the same identity they set on temporal.api.workflowservice.v1.StartWorkflowExecutionRequest.identity. So a top-level workflow and a child-workflow started from the same SDK client will have the same value.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how temporal.api.history.v1.WorkflowExecutionStartedEventAttributes.identity is populated for child workflows and how RespondWorkflowTaskCompletedRequest.identity is handled. Compare this with StartWorkflowExecutionRequest.identity, then verify that a child workflow receives the same identity as its top-level workflow when both originate from the same SDK client.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design, distributed-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100