temporalio / temporalio/temporal
Throttled logger should not throttle errors that happens rarely
Open
Nobody has claimed this yet.
enhancement
up-for-grabs
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Throttled logger will rate limit all log lines equally.
We can do much better job to throttle only frequently repeat log lines.
Current throttled logger likely will miss important error log lines if they happen rarely while hit by rps limit.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with common/log/throttle_logger.go at the linked throttled logger implementation and inspect its callers and existing tests. Clarify the intended treatment of rarely repeated error lines, then add coverage showing that important infrequent errors are not suppressed while repeated lines remain throttled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability-sre
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100