temporalio / temporalio/temporal
Ability to disable dynamic config in auto-setup docker image
Open
@alexshtin is already working on this.
Since Feb 11, 2022.
enhancement
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
I tried to launch auto-setup docker image without DYNAMIC_CONFIG_FILE_PATH env var and got an error.
Expected Behavior
Server started without dynamic configuration features.
Actual Behavior
Server startup failed with Unable to create dynamic config client. Error: unable to read dynamic config: dynamic config file: /etc/temporal/config/dynamicconfig: read /etc/temporal/config/dynamicconfig: is a directory error.
Specifications
Image: temporalio/auto-setup:1.14.4
PS
Looks like a bug in config_template.yaml: segment dynamicConfigClient should be wrapped with {{- if .Env.DYNAMIC_CONFIG_FILE_PATH }}.
Ready for PR.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.