temporalio / temporalio/temporal

import of github.com/cactus/go-statsd-client is ambiguous in go.temporal.io/server

Open
#2,403 1 comment 0 reactions 1 assignee View on GitHub

@Ardagan is already working on this.

Since Jan 21, 2022.

potential-bug
Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

Expected Behavior

updating packages for embedded temporal , from go.temporal.io/server v1.9.2 to go.temporal.io/server v1.14.3
go mod tidy works fine

Actual Behavior

go mod tidy fails
temp_test imports
go.temporal.io/server/common/authorization imports
go.temporal.io/server/common/metrics imports
github.com/cactus/go-statsd-client/statsd loaded from github.com/cactus/go-statsd-client/statsd@v0.0.0-20200423205355-cb0885a1018c,
but go 1.16 would fail to locate it:
ambiguous import: found package github.com/cactus/go-statsd-client/statsd in multiple modules:
github.com/cactus/go-statsd-client v3.1.1+incompatible (.../go/pkg/mod/github.com/cactus/go-statsd-client@v3.1.1+incompatible/statsd)
github.com/cactus/go-statsd-client/statsd v0.0.0-20200423205355-cb0885a1018c (../go/pkg/mod/github.com/cactus/go-statsd-client/statsd@v0.0.0-20200423205355-cb0885a1018c)

Steps to Reproduce the Problem

  1. use go.temporal.io/server v1.9.2 in code
    sample:
    package main

    import (
    "go.temporal.io/server/common/authorization"
    "go.temporal.io/server/common/config"
    "log"
    )

    func main() {
    cfg := config.Authorization{}
    _, err := authorization.GetAuthorizerFromConfig(&cfg)
    if err != nil {
    log.Println(err)
    }
    }

  2. go get -u go.temporal.io/server

  3. go mod tidy

Specifications

  • Version: go version go1.17.5
  • Platform: ubuntu 20 (same on windows)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.