temporalio / temporalio/temporal
Reduce unnecessary & duplicated data encoding
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
current implementation of logic allow per attribute encoding, e.g. activity have its own encoding, child workflow can have its own encoding. per attribute encoding can in theory allow more flexibility, but in reality, only proto3 is used.
in fact, business logic object (binary) only need one encoding type.
Update the following structs, replace DataBlob with []byte
InternalWorkflowMutableState / InternalWorkflowMutation / InternalWorkflowSnapshot
InternalWorkflowMutableState
InternalWorkflowMutation
InternalWorkflowSnapshot
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in common/persistence/persistenceInterface.go at InternalWorkflowMutableState, InternalWorkflowMutation, and InternalWorkflowSnapshot. Trace references to their DataBlob fields across the repository before changing the fields to []byte. Done means all three structs and their callers consistently use []byte without per-attribute encoding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100