temporalio / temporalio/temporal
Add ActivityTaskStarted event immediately if RetryOptions.maximumAttempts is set to 1.
@feedmeapples is already working on this.
Since Apr 16, 2021.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Is your feature request related to a problem? Please describe.
The ActivityTaskStarted event is added to the history only after an activity is completed to avoid polluting history on activity retries. This is confusing especially when the retries are turned off by setting RetryOptions.maximumAttempts to 1.
Describe the solution you'd like
Add ActivityTaskStarted immediately to the history if retries are disabled by setting RetryOptions.maximumAttempts to 1.
Consider adding ActivityTaskStarted immediately for the first attempt even if the activity has a retry options with non 1 maximumAttempts. In case of failure write ActivityTaskFailed only for the first attempt and then continue with the current logic. I would also add some field to ActivityTaskFailed/TimedOut that indicates that retries are going to happen.
Describe alternatives you've considered
Make UI only changes to surface that activity is in retry.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.