temporalio / temporalio/temporal

Make output streams of logger configurable perfectly

Open
#1,423 0 comments 1 reaction 2 assignees View on GitHub

@Ardagan is already working on this.

Since Apr 2, 2021.

enhancement operations
Dominant language
Go
Stars
23.2k
Forks
1.9k
Avg merge
2d 8h
Merged PRs (30d)
228

Description

Is your feature request related to a problem? Please describe.

Google Cloud Platform collects logs output to stderr as error (means that Severity is ERROR ) and those output to stdout as non-error. When the temporal server outputs the log, whether the log level is INFO or ERROR , it outputs to the same output stream, so everything gets mixed up.

Because of this, I want the feature that configures OutputPaths and ErrorOutputPaths of loggers.

Describe the solution you'd like

Add OutputPaths and ErrorOutputPaths fields to this:
https://github.com/temporalio/temporal/blob/a04944a0a174a22745f52e64128ca7c1331e792a/common/log/config.go#L29-L36

And set those to the logger config:
https://github.com/temporalio/temporal/blob/a04944a0a174a22745f52e64128ca7c1331e792a/common/log/zap_logger.go#L199-L200

Describe alternatives you've considered

None.

Additional context

We may want to consider what to do with existing configuration fields such as Stdout and OutputFile.
I think we should leave it at that for compatibility.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.