temporalio / temporalio/temporal
CHASM/System Nexus: SignalWithStart doesn't validate cron schedules
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 23.2k
- Forks
- 1.9k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 228
Description
Expected Behavior
SDK Client's SignalWithStartWorkflowExecution is usually validated by the Frontend here: service/frontend/workflow_handler.go#L2336
The SDK team is working on supporting SignalWithStartWorkflowExecution from inside a workflow, via System Nexus. The relevant system nexus validation code is here: chasm/lib/workflow/nexus_service.go#L79
I expect the server to do the same validation on signal-with-start requests in system nexus as it does in the frontend. In particular, the frontend invokes backoff.ValidateSchedule to check that cron strings are syntactically valid.
Actual Behavior
temporal-server/chasm/lib/workflow/nexus_service.go doesn't seem to invoke backoff.ValidateSchedule on cron strings. Maybe we want to move cron validation from WorkflowHandler.SignalWithStartWorkflowExecution to RequestValidator.ValidateSignalWithStartRequest?
Steps to Reproduce the Problem
Specifications
- Version:
- Platform:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with chasm/lib/workflow/nexus_service.go#L79 and compare its SignalWithStart validation with service/frontend/workflow_handler.go#L2336, including the existing backoff.ValidateSchedule call. Check whether RequestValidator.ValidateSignalWithStartRequest is the right shared entry point; done means System Nexus rejects syntactically invalid cron schedules like the frontend path does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design, distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100