temporalio / temporalio/temporal-worker-controller
Inactive WorkerDeploymentVersions with no open pinned workflow executions never cleaned up
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 187
- Forks
- 70
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 31
Description
A rollout superseded before its version becomes Current or Ramping stays Inactive forever.
The controller scales its Deployment to zero, but the controller only cleans up the Temporal-side WorkerDeploymentVersion and the k8s-side Deployment for Drained and NotRegistered versions, not Inactive.
We should add cleanup for Inactive versions but only after checking with the CountWorkflow visibility query that there are no open pinned workflow executions targeting that specific build ID (which could be the case if a user executed the workflow with versioning override pinning to that build ID.
OP: @mitchross
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the controller cleanup handling for Drained and NotRegistered WorkerDeploymentVersions, then trace the CountWorkflow visibility query and its build-ID filtering. Done means an Inactive version and its Kubernetes Deployment are cleaned up only when no open pinned workflow executions target that specific build ID.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- devops, infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100