temporalio / temporalio/temporal-worker-controller
Add Finalizer for Deployment Resources to prevent deletion of Deployments that are polling non-Drained versions
@jlegrone is already working on this.
Since Jul 2, 2025.
- Dominant language
- Go
- Stars
- 187
- Forks
- 70
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 31
Description
Add finalizers to Deployment resources created by the controller to prevent clients from directly deleting them before workflow executions are properly drained. When a user attempts to delete a deployment, the finalizer ensures the controller can coordinate proper draining of that worker version before allowing the deletion.
A requested deletion should probably still trigger an immediate scale-to-zero for the deployment; scaledown is reversible however if the user chooses to remove the .metadata.deletionTimestamp marker.
https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.